Expose the Lock ID on the locks page #127
Conversation
kraih
requested review from
a team,
marcusramberg,
kraih,
jhthorsen and
jberger
stuartskelton
force-pushed
the
expose_lock_id_on_locks_page
branch
from
ee541da to
4f7873f
Compare
|
Thanks for the pointers. I have added the changes and added the test. I also took the time to add some tests for the status endpoint for the locks too. |
Changes
Outdated
| @@ -1,5 +1,6 @@ | |||
|
|
|||
| 10.29 2023-11-28 | |||
| - Improved admin ui to show the lock ID on the locks page. | |||
There was a problem hiding this comment.
Don't write your own Changes entries please, those are done by the maintainers.
There was a problem hiding this comment.
Instead it needs to be mentioned in the documentation, like the other fields.
There was a problem hiding this comment.
you are correct, I have corrected this.
|
And don't forget to squash your commits when you are ready for review. |
stuartskelton
force-pushed
the
expose_lock_id_on_locks_page
branch
from
4f7873f to
01bab6f
Compare
stuartskelton
force-pushed
the
expose_lock_id_on_locks_page
branch
from
01bab6f to
183b7ba
Compare
lib/Minion/Backend/Pg.pm
Outdated
| id => 1 | ||
|
|
||
| Lock id. | ||
|
|
There was a problem hiding this comment.
There are multiple places where this needs to be added. Also the fields are in alphabetical order.
There was a problem hiding this comment.
Updated Backend.pm, I think this was the only other place I neede
|
Also a perltidy fix is needed. There will be a new Minion release in a few hours, if the mentioned points are resolved this PR can be included. |
stuartskelton
force-pushed
the
expose_lock_id_on_locks_page
branch
from
183b7ba to
d1489cf
Compare
stuartskelton
force-pushed
the
expose_lock_id_on_locks_page
branch
from
d1489cf to
90cbf56
Compare
|
ok, PT'ed the test. |
Summary
Expose the lock ID on the Minion admin locks page
Motivation
I employ locks to manage job execution across multiple worker boxes. However, apart from querying the database, I'm unable to determine whether the locks are being rotated. The expiration time decreasing provides some indication, but if the jobs finish within a minute, I can't tell solely from the lock screen whether they are cycling or being held for that minute.
Since it's only retrieving the ID, which would be part of the index, there should be no slowdown in the database.
References
Sorry this is a drive by pull request